Allow Digit Characters in Header Names#16
Open
gthole wants to merge 13 commits intointernetarchive:masterfrom
Open
Allow Digit Characters in Header Names#16gthole wants to merge 13 commits intointernetarchive:masterfrom
gthole wants to merge 13 commits intointernetarchive:masterfrom
Conversation
allow dots in warc headers
log warning on bad header read
Simplified WARC Reader
generalized simple warc reader line reading and added fileobj and iterat...
fixed bug where reader failed with bad linebreak format, added tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response header names can contain digit characters:
http://en.wikipedia.org/wiki/P3P
Reading a record with a "P3P" header will throw an
IOErrorfor a "Bad header", even though the header is legitimate.Example when creating a record from the W3 Consortium homepage:
A modififcation to the unit tests is included to confirm.
Thanks!
Greg